Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE #43 #46

Closed
wants to merge 1 commit into from
Closed

ISSUE #43 #46

wants to merge 1 commit into from

Conversation

Ankush1oo8
Copy link

Resolved Issue #43
#Positional vs. Optional Arguments:

##Original Code: The original code did not contain any positional arguments that were explicitly defined. All arguments were optional, but there was no confusion regarding their types.
##Modified Code: The modified code maintains the use of only optional arguments (with - or -- prefixes). This ensures clarity and avoids any potential confusion or errors related to the required parameter.

##Error Handling:
The modified code does not introduce any changes to error handling logic; it retains the same checks for negative values for days_before and days_after. However, it ensures that no invalid usage of required is present.

##Help Messages:
While both versions have help messages for each argument, the modified version slightly refines these messages for clarity and consistency.

##Code Structure:
The overall structure of the code remains unchanged in terms of functionality. The logic for creating directories, initializing the Git repository, generating commits, and pushing to a remote repository is preserved.

##Commenting:
In the modified version, comments were added to clarify what changes were made, particularly regarding the handling of command-line arguments.

@Shpota
Copy link
Owner

Shpota commented Nov 6, 2024

Hi @Ankush1oo8

Thank you for the contribution. What was the issue? How to reproduce it and what part for your PR fixes it?

@Ankush1oo8
Copy link
Author

I have written in description that

Copy link

@meellonmusk meellonmusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring

@Ankush1oo8
Copy link
Author

Means

@Ankush1oo8 Ankush1oo8 closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants